Make master connections respect driverOptions #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verOptions Reverts the changes made in doctrine#1240, and applies the passing down of `driverOptions` manually in `CreateDatabaseDoctrineCommand` and `DropDatabaseDoctrineCommand` Resolves doctrine#1252
ostrolucky
changed the title
simPod
added a commit
to simPod/DoctrineBundle
that referenced
this pull request
Apr 11, 2022
This reverts commit 5a94ec5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the changes made in #1240, and applies the passing down of
driverOptionsmanually inCreateDatabaseDoctrineCommandandDropDatabaseDoctrineCommandResolves #1252
I haven't written any tests for this - it seems that these commands aren't particularly testable due to the static call to
DriverManager::getConnection. It's not straightforward to verify the params that are passed to it. I considered refactoring the seemingly common code in both commands into a single parent methods, but there's slight differences between them that makes me wary of breaking something.