Propagate template from EntityRepository #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostrolucky
approved these changes
Jan 27, 2021
dmaicher
approved these changes
Jan 27, 2021
stof
reviewed
Jan 27, 2021
greg0ire
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
I could try to add it during some of my free time.
That would be much appreciated! There is a template for that here in case you're not already aware of that.
UPD: you must be aware already since you created doctrine/common#920
|
Thanks @VincentLanglet ! |
|
Hi @greg0ire, what is needed for the next release ? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @greg0ire, seems like there is no psalm on this project
I could try to add it during some of my free time.
This PR avoid to a
TooManyTemplateParamserror from psalm and allow to benefit from theObjectRepository<T>interface.