Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Charset passed via URL is overridden #1363

Merged
merged 4 commits into from
Jun 1, 2021
Merged

Fix Charset passed via URL is overridden #1363

merged 4 commits into from
Jun 1, 2021

Conversation

saleh199
Copy link
Contributor

@saleh199 saleh199 commented Jun 1, 2021 •
edited
Loading

@saleh199 saleh199 changed the title Fix Charset passed via URL is overridden #1325 Fix Charset passed via URL is overridden Jun 1, 2021
nicolas-grekas
nicolas-grekas approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!. Just please fix the cs report.

@ostrolucky ostrolucky changed the base branch from 2.3.x to 2.4.x June 1, 2021 21:34
@ostrolucky
Copy link
Member

needs to go to 2.4

@ostrolucky ostrolucky added this to the 2.4.2 milestone Jun 1, 2021
@ostrolucky ostrolucky merged commit aa17a6c into doctrine:2.4.x Jun 1, 2021
@ostrolucky
Copy link
Member

thank you @saleh199

@saleh199 saleh199 deleted the fix-1325 branch June 1, 2021 21:57
ostrolucky pushed a commit that referenced this pull request Jun 3, 2021
@saleh199 @ostrolucky
Fix Charset passed via URL is overridden (#1363)
2c313a0
@github-actions github-actions bot mentioned this pull request Jun 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostrolucky ostrolucky ostrolucky approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@saleh199 @ostrolucky @nicolas-grekas