Run PHPCS on PHP 8 #1400
Merged
Run PHPCS on PHP 8 #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostrolucky
reviewed
Sep 11, 2021
| @@ -17,7 +17,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| php-version: | |||
| - "7.4" | |||
| - "8.0" | |||
There was a problem hiding this comment.
Perhaps we should run it with 7.1, that's the compatibility we need to maintain.
There was a problem hiding this comment.
I've added 7.1 as well.
There was a problem hiding this comment.
🤔 I think one run should be enough, if we add <config name="php_version" value="70100"/> to the configuration.
There was a problem hiding this comment.
Yes, that does the trick. I could even remove two more rules from the exclude list now. 🎉
derrabus
force-pushed
the
improvement/phpcs-on-php8
branch
from
ada2550 to
a955bb1
Compare
ostrolucky
approved these changes
Sep 11, 2021
Signed-off-by: Alexander M. Turek <me@derrabus.de>
derrabus
force-pushed
the
improvement/phpcs-on-php8
branch
from
a955bb1 to
d761625
Compare
SenseException
approved these changes
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.