Fix ProfilerController compatibility with Symfony 6 #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostrolucky
force-pushed
the
fix-explain
branch
from
b44a583 to
4aac5cb
Compare
stof
reviewed
Dec 11, 2021
| @@ -233,5 +233,13 @@ | |||
|
|
|||
| <tag name="console.command" command="doctrine:mapping:import" /> | |||
| </service> | |||
|
|
|||
| <service id="Doctrine\Bundle\DoctrineBundle\Controller\ProfilerController"> | |||
| <argument type="service" id="twig" on-invalid="ignore"/> | |||
There was a problem hiding this comment.
on-invalid="ignore" is wrong, as the class cannot be instantiated without that argument.
There was a problem hiding this comment.
And that's fine, I don't want that controller instantiated without those arguments, as it would be useless. It cannot work without them.
There was a problem hiding this comment.
but why adding this on-invalid="ignore" then ?
There was a problem hiding this comment.
Because twig and profiler are registered only in certain configurations, as discovered by tests.
dmaicher
reviewed
Dec 13, 2021
ostrolucky
force-pushed
the
fix-explain
branch
from
4aac5cb to
1f853a0
Compare
dmaicher
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1442