Fix error for logging middleware when logger is missing

[l-vo]

Fix #1487

[dmaicher]

thanks for looking into this 👍

[l-vo]

@dmaicher changes applied

[dmaicher]

@loic425 could you confirm that this fixes #1487 for you? tested it myself.

[dmaicher]

Tested it myself: Works fine if no logger service is defined and fixes #1487

@ostrolucky do you want to have a look? Or shall I go ahead and merge it?

[ostrolucky]

I probably won't review this today. You can go ahead if you feel this is urgent. I don't personally see the urgency: who the heck doesn't have logger in prod?

[loic425]

Thank you! I'll try on monday. Have a good weekend

[yura3d]

@l-vo Is it really need to always remove doctrine.dbal.logging_middleware definition in case no service named logger presents in container, even if the definition itself contains argument with its own logger?

DoctrineBundle/DependencyInjection/Compiler/RemoveLoggingMiddlewarePass.php

Lines 9 to 19 in 0ad7b24

	final class RemoveLoggingMiddlewarePass implements CompilerPassInterface
	{
	public function process(ContainerBuilder $container)
	{
	if ($container->has('logger')) {
	return;
	}
	$container->removeDefinition('doctrine.dbal.logging_middleware');
	}
	}

I'm trying to set my custom SQLLogger service only for DBAL logs (if I name it logger, it starts to receive symfony-specific logs, that I don't need):

App\Doctrine\SQLLogger:
    arguments:
        $logFilename: '%kernel.logs_dir%/sql.log'
doctrine.dbal.logging_middleware:
    class: 'Doctrine\DBAL\Logging\Middleware'
    arguments:
        - '@App\Doctrine\SQLLogger'

And this config doesn't work until I do something like this:

logger:
    class: 'Psr\Log\NullLogger'

[l-vo]

@yura3d What about using your own service id instead of reusing doctrine.dbal.logging_middleware ? You just need to add the doctrine.middleware tag or enable autoconfiguration for the service.

[yura3d]

@l-vo Sorry, seems I didn't read the docs carefully. Thanks!