Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow configuring schema manager factory #1632

Merged
merged 12 commits into from
Feb 28, 2023
Merged

allow configuring schema manager factory #1632

merged 12 commits into from
Feb 28, 2023

Conversation

dmaicher
Copy link
Contributor

@dmaicher dmaicher commented Feb 11, 2023 •
edited
Loading

Will get rid of this deprecation

  1x: Not configuring a schema manager factory is deprecated. Use Doctrine\DBAL\Schema\DefaultSchemaManagerFactory which is going to be the default in DBAL 4. (Connection.php:225 called by DriverManager.php:193, https://github.com/doctrine/dbal/issues/5812, package doctrine/dbal)

Also see doctrine/dbal#5876

@dmaicher dmaicher force-pushed the schema_manager_factory branch from ef7b1bd to cbcca93 Compare February 11, 2023 11:47
@dmaicher dmaicher added this to the 2.9.0 milestone Feb 11, 2023
@dmaicher dmaicher force-pushed the schema_manager_factory branch 3 times, most recently from 48586dc to 7985988 Compare February 11, 2023 12:20
@dmaicher dmaicher marked this pull request as ready for review February 11, 2023 12:22
@dmaicher dmaicher marked this pull request as draft February 17, 2023 16:31
@ostrolucky ostrolucky self-requested a review February 17, 2023 16:53
@dmaicher dmaicher force-pushed the schema_manager_factory branch from 07d8a90 to 4e48cf4 Compare February 22, 2023 20:11
dmaicher
dmaicher commented Feb 27, 2023
View reviewed changes
UPGRADE-2.9.md Outdated Show resolved Hide resolved
@dmaicher dmaicher marked this pull request as ready for review February 27, 2023 20:22
@dmaicher dmaicher force-pushed the schema_manager_factory branch from e1a6697 to 083bf74 Compare February 28, 2023 07:49
@dmaicher dmaicher merged commit 402d02b into doctrine:2.9.x Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus left review comments

@stof stof stof left review comments

@ostrolucky ostrolucky ostrolucky approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dmaicher @stof @ostrolucky @derrabus