Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a setting to opt-in for the XSD validation for mapping #1670

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

stof
Copy link
Member

@stof stof commented Jun 5, 2023

Closes #1647

@stof stof added this to the 2.10.0 milestone Jun 5, 2023
@ostrolucky
Copy link
Member

ostrolucky commented Jun 5, 2023

This means we can remove issue from https://github.com/doctrine/DoctrineBundle/blob/2.9.x/Tests/baseline-ignore now, right?

@stof
Copy link
Member Author

stof commented Jun 5, 2023

@ostrolucky indeed. I removed it now (removing the baseline file entirely as it is empty) by fixing the remaining test triggering the error.

@stof
Copy link
Member Author

stof commented Jun 5, 2023

@ostrolucky @dmaicher I suggest that once this PR is merged, we trigger the 2.10.0 release. This would allow shipping this code to projects upgrading to Symfony 6.3 to avoid getting new reports about deprecations. I see no reason to delay the release (we have nothing else in-progress and that's the last deprecation was can solve in the bundle itself as the remaining one is in the ORM code)

@stof stof requested review from dmaicher and ostrolucky June 5, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants