fix tests with Symfony 7 due to Annotation support removal #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
force-pushed
the
fix_symfony_7
branch
from
4452bb2 to
4f80bc1
Compare
dmaicher
commented
Oct 22, 2023
| @@ -489,7 +491,7 @@ public function testSingleEntityManagerMultipleMappingBundleDefinitions(): void | |||
| $definition = $container->getDefinition('doctrine.orm.default_metadata_driver'); | |||
|
|
|||
| $this->assertDICDefinitionMethodCallAt(0, $definition, 'addDriver', [ | |||
| new Reference('doctrine.orm.default_annotation_metadata_driver'), | |||
| new Reference(class_exists(AnnotationLoader::class) ? 'doctrine.orm.default_annotation_metadata_driver' : 'doctrine.orm.default_attribute_metadata_driver'), | |||
There was a problem hiding this comment.
not so happy with this detection for Symfony 7 and removed annotations support.
Anyone got a better idea?
I tried $container->has('annotations.reader') but it fails since we are not loading the FrameworkExtension in tests.
There was a problem hiding this comment.
Inside a DI extension, the ContainerBuilder won't have any of the services defined by other extensions anyway.
ostrolucky
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.