Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark DoctrineMetadataCacheWarmer final + add $buildDir arg #1713

Merged
merged 1 commit into from
Oct 23, 2023
Merged

mark DoctrineMetadataCacheWarmer final + add $buildDir arg #1713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CacheWarmer/DoctrineMetadataCacheWarmer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

use function is_file;

/** @final since 2.11 */
class DoctrineMetadataCacheWarmer extends AbstractPhpFileCacheWarmer
{
private EntityManagerInterface $entityManager;
Expand All @@ -31,8 +32,7 @@
return false;
}

/** @param string $cacheDir */
protected function doWarmUp($cacheDir, ArrayAdapter $arrayAdapter): bool
protected function doWarmUp(string $cacheDir, ArrayAdapter $arrayAdapter, ?string $buildDir = null): bool

Check warning on line 35 in CacheWarmer/DoctrineMetadataCacheWarmer.php

View check run for this annotation

Codecov / codecov/patch

CacheWarmer/DoctrineMetadataCacheWarmer.php#L35 

Added line #L35 was not covered by tests
{
// cache already warmed up, no needs to do it again
if (is_file($this->phpArrayFile)) {
Expand Down