Enable report_fields_where_declared for ORM 3 #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah nice 👍 I actually wanted to look into it myself in the next days as I also encountered then issue in sonata-project/sonata-doctrine-extensions#494 (comment) |
|
Seems there are some related test failures 🤔 https://github.com/doctrine/DoctrineBundle/actions/runs/6870900826/job/18686699968?pr=1729 |
derrabus
force-pushed
the
bugfix/rfwd-orm3
branch
from
3a6c2d9 to
126d055
Compare
|
The test should be fixed now. |
dmaicher
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
report_fields_where_declareddefault tofalsedoes not make sense if ORM 3 is installed because it will result in a unusable driver configuration.This PR picks a smart default depending on the installed ORM version. On top of that, it disallows opting out of the
report_fields_where_declaredsetting when ORM 3 is installed.