Fix the DoctrineOrmMappingsPass passing null as the file extension argument of the XmlDriver #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gument of the XmlDriver
|
Dupe with #1752 |
|
Well, but it's a better commit message at least. So I'll merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
createXmlMappingDrivermethod of the DoctrineOrmMappingsPass is passing null as the file extension argument, while the XmlDriver expects it to be a string, generating a TypeError.The error was raised only by trying to upgrade to orm 3.0. I did not have any issue in 2.18.
This is however quite concerning since it prevents the usage of a bundle like Messenger Monitor on a project using doctrine/orm 3.0