Fix doctrine:database:create and doctrine:database:drop for Postgresql on DBAL 4.x #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Feb 20, 2024
| @@ -64,6 +65,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| /** @psalm-suppress InvalidArrayOffset Need to be compatible with DBAL < 4, which still has `$params['url']` */ | |||
| unset($params['dbname'], $params['path'], $params['url']); | |||
|
|
|||
| if ($connection->getDatabasePlatform() instanceof PostgreSQLPlatform) { | |||
| $params['dbname'] = 'postgres'; | |||
| } | |||
There was a problem hiding this comment.
Why do we unset dbname on line 66, only to set it again here? Also, I don't understand the comment on line 64, should it read "as we have already extracted" instead of "and we have already extracted"?
There was a problem hiding this comment.
For the first point, it's because I assume unsetting dbname might still be needed for other db platforms. For the second point: I guess so.
greg0ire
approved these changes
Feb 20, 2024
…l on DBAL 4.x Ref doctrine/dbal#5705 Fixes #1757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref doctrine/dbal#5705
Fixes #1757