Fix wiring of PHP metadata drivers on doctrine/orm 3.x

[MatTheCat]

Follows symfony/symfony#33319, takes over #1755 and fixes symfony/symfony#58738.

Some metadata drivers were removed in doctrine/orm 3 and must then be used from doctrine/persistence.

Since the parameters used to infer their class name are deprecated, this PR rewrites getMetadataDriverClass so that it selects the right one.

Note that some class parameters are still used in the DoctrineExtension but I considered them out of this PR’s scope.

[ostrolucky]

Looks like tests will need fixing. And for SA issues you can suppress them.

[MatTheCat]

Hm should I split tests into AnnotationDriver-exists-or-not? Or sprinkle them with class_exists? 🤔

[ostrolucky]

My preference would be to upgrade current tests to use attribute instead of annotation and skip them for orm < 3.x

[stof]

We don't need to skip them for ORM 2.x AFAIK. Attributes are supported there as well (on PHP 8+)

[MatTheCat]

Do I keep the DoctrineExtensionTest::testAnnotationsBundleMappingDetection?

[ostrolucky]

you can remove it

[MatTheCat]

Okay, done. Not sure why some tests are still failing though 🤔

[ostrolucky]

I think those test failures are a symptom of this branch not being triggered now :( https://github.com/symfony/symfony/blob/c905bb4db3eec98e156199341891f62247f83fb6/src/Symfony/Bridge/Doctrine/DependencyInjection/AbstractDoctrineExtension.php#L224

[MatTheCat]

Waat so the Doctrine Bridge does need to be updated 😅

[ostrolucky]

I don't know, just saying that's the cause why tests fail. Proper course of action would be to find out why was that code branch added and find if same reasoning still applies nowadays. Then we know if we need to preserve the behavior somehow, or adjust tests

[MatTheCat]

See symfony/symfony#53681; seems that we cannot be compatible with Symfony < 6.4 by returning XML and YAML drivers’ class name instead of the parameter.

[MatTheCat]

Maybe this PR should focus to simply returning the correct PHP driver’s class name? That would fix symfony/symfony#58738, hopefully without any side effect.

[ostrolucky]

I believe we just need to backport symfony/symfony#53681 to 5.4 branch. It's either that, or we cut off symfony/doctrine-bridge 5.4.x support here

[MatTheCat]

Okay opened symfony/symfony#58772

[MatTheCat]

Woops this got closed with symfony/symfony#58772 and I cannot reopen it 😓

Can someone do it for me or should I open another PR?

EDIT: thanks @nicolas-grekas 🙏

[ostrolucky]

Last thing needed here I think is to adjust symfony/doctrine-bridge requirement to ensure we don't install < 5.4.46 version

[MatTheCat]

Shouldn’t the ^6.0.7 constraint be bumped to ^6.4.3 and ^7.0 to ^7.0.3 so that we’re sure we got the fix?

[ostrolucky]

indeed

[MatTheCat]

CI is green 🎉