Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix page for CustomIdGenerator attribute #1834

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

samnela
Copy link
Contributor

@samnela samnela commented Nov 7, 2024

No description provided.

@SenseException
Copy link
Member

Thank you for your contribution. 2.12 isn't supported anymore and the current 2.13 version already uses Attributes in the CustomIdGenerator, but the link in your PR, that you fixed, still needs to target the correct docs page. Can you please target 2.13 in your PR and fix the link?

@samnela samnela changed the base branch from 2.12.x to 2.13.x November 7, 2024 23:41
@samnela samnela force-pushed the patch-1 branch 2 times, most recently from 4be9832 to 1b80a7b Compare November 7, 2024 23:43
@samnela
Copy link
Contributor Author

samnela commented Nov 7, 2024

Hello, I changed the target and also added the #[ORM\Entity] attribute because I didn't find it on the 2.13.x or 2.14.x branches

@ostrolucky ostrolucky added this to the 2.13.1 milestone Nov 8, 2024
@SenseException SenseException merged commit 2740ad8 into doctrine:2.13.x Nov 8, 2024
16 checks passed
@SenseException
Copy link
Member

Thanks @samnela

@samnela samnela deleted the patch-1 branch November 8, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants