Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kernel.build_dir by default for proxy dir and metadata cache #1843

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

alexndlm
Copy link

No description provided.

@ostrolucky
Copy link
Member

why?

@alexndlm alexndlm changed the title Use kernel.build_dir by default for proxy dir Use kernel.build_dir by default for proxy dir and metadata cache Nov 26, 2024
@stof
Copy link
Member

stof commented Nov 26, 2024

Given that the proxies and the metadata cache are directly derived from the source code and can be fully warmed up, I think this makes sense.
It makes things better for project wanting to deploy with a readonly file system, separating things that get generated during the build from things written in the writable cache folder (potentially treated as ephemeral).
Note that by default, Symfony does not separate the build directory from the cache directory. It requires an explicit opt-in.

@ostrolucky ostrolucky added this to the 2.14.0 milestone Nov 26, 2024
@ostrolucky ostrolucky changed the base branch from 2.13.x to 2.14.x November 26, 2024 16:39
@ostrolucky ostrolucky changed the base branch from 2.14.x to 2.13.x November 26, 2024 16:39
@ostrolucky ostrolucky changed the base branch from 2.13.x to 2.14.x November 26, 2024 16:40
@ostrolucky ostrolucky changed the base branch from 2.14.x to 2.13.x November 26, 2024 16:40
@ostrolucky ostrolucky changed the base branch from 2.13.x to 2.14.x November 26, 2024 16:41
@ostrolucky ostrolucky merged commit 9fe3b63 into doctrine:2.14.x Nov 26, 2024
15 checks passed
@stof
Copy link
Member

stof commented Nov 27, 2024

However, seeing no changes in cache warmers looks a bit suspicious to me. I thought that cache warmers needed to use their second argument to properly warm up the build directory during the cache:warmup command.

@ostrolucky
Copy link
Member

Change of $phpArrayFile in DoctrineExtension modifies this argument that's passed to DoctrineMetadataCacheWarmer. Do you think there is something else to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants