Fix attribute driver mapping pass compatibility with ORM 3 #2120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobvandevijver
force-pushed
the
mapping-pass
branch
2 times, most recently
from
d42c473 to
82fb7b1
Compare
bobvandevijver
changed the title
greg0ire
reviewed
Oct 24, 2025
| $driverArgs[] = $reportFieldsWhereDeclared; | ||
| } | ||
|
|
||
| $driver = new Definition(AttributeDriver::class, $driverArgs); |
Member
There was a problem hiding this comment.
It would be great to cover this method with a test that creates a container, adds the compiler pass returned by this method, compiles it and then attempts to retrieve the driver service from it.
Member
|
@bobvandevijver do you still plan to work on this? |
bobvandevijver
force-pushed
the
mapping-pass
branch
from
82fb7b1 to
007838c
Compare
bobvandevijver
force-pushed
the
mapping-pass
branch
from
007838c to
c60a160
Compare
Contributor
Author
|
@greg0ire Thanks for the ping, this completely slipped my mind! I've added the requested test, I hope it aligns with what you meant! |
bobvandevijver
commented
Dec 22, 2025
| public function testAttributeDriverIsRegistered(): void | ||
| { | ||
| $driverNamespace = 'DoctrineBundle\Entity'; | ||
| $container = $this->createXmlBundleTestContainer( |
Contributor
Author
There was a problem hiding this comment.
I re-used this method as the compiler pass requires almost everything to be configured, such as the default entity manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not completely happy with my method of detecting ORM v2 (it uses the presence of a removed method in v3), but it works. Fixes #1844.