Allow defaultTableOptions to be configured #420

DHager · 2015-05-05T18:34:31Z

Change configuration metadata to unlock the use of defaultTableOptions, so that defaults can be passed to the schema-tool. In the case of MySQL, possible defaults include charset, collation, and engine.

The array-data is taken up here and then applied by individual platforms.

…TableOptions

DHager · 2015-05-21T03:06:07Z

I'm assuming that documentation for this option will involve a separate, future PR against the separate symfony-docs repo.

So besides that, is there anything else I can do to help move this feature forward?

stof · 2015-05-22T09:32:05Z

@DHager Please add the documentation in the Resources/doc folder

DHager · 2015-05-22T18:11:34Z

@stof OK, I added some samples to the documentation folder. I can't enumerate all the possible options because they are situation-dependent on some DBAL platform internals.

Stylistically, default_table_options (in YAML) and default-table-option (in XML) would look a lot nicer, but the DBAL layer would still be looking for defaultTableOptions, and I'm not certain what the best mechanism would be for doing that conversion.

stof · 2015-05-28T11:49:39Z

@DHager we already have such a mechanism in the DoctrineExtension to rename keys to camelCase

stof · 2015-05-28T11:50:16Z

DependencyInjection/Configuration.php

@@ -153,6 +153,11 @@ private function getDbalConnectionsNode()
                    ->useAttributeAsKey('name')
                    ->prototype('scalar')->end()
                ->end()
+                ->arrayNode('defaultTableOptions')


you are missing the ->fixXmlConfig() on the parent node for the XML to work properly

…ore issues.

DHager · 2015-06-06T02:13:36Z

@stof : The pluralization is now fixed, but what I meant is that I'm not sure if there's a worthwhile way to let the user specify default-table-option (XML tag) and default_table_option (YAML key) while still putting something called defaultTableOptions into Doctrine-DBAL.

DHager · 2015-06-09T16:43:31Z

@stof: I think this one is done. Personally, it removes the need for a lot of <options> in every entity stating the desired character set and collation.

DHager · 2015-07-16T04:13:57Z

Are there any changes or checks I can do to help move this one along?

stof · 2015-07-20T15:47:05Z

the XML conventions are to use dash-separated words in keys, and the Yaml convention is to use snake_case. So yes, I would use such names in the config (we already have some logic in the DI extension converting to camelCase for Doctrine names; you just need to add it in the list)

DHager · 2015-07-22T01:24:06Z

OK, so you're saying that the meta-configuration layer does not handle all three varieties, only the dash and underscore variety, and any conversion to camelCase must be done with some ad-hoc code, correct? Perhaps in DoctrineExtension::dbalLoad()?

Are you sure all this convention-juggling is necessary? To some extent this is not structured configuration for the bundle to consume, but a complex payload we just want to pass-through so that DBAL can consume and interpret. (There are also several documented sibling-keys which break the pattern, such as sessionMode, sslmode, and MultipleActiveResultSets.)

…table_options (or dashed, if XML) Add renaming step to the extension so that DBAL layer is still satisfied seeing defaultTableOptions

DHager · 2015-07-22T02:27:08Z

OK, I've added some code that--after loading configurations--renames/replaces them as camelCase. The rename has to occur in order to satisfy DBAL code in AbstractSchemaManager which looks specifically for that string.

DHager · 2015-07-30T20:20:32Z

@stof : It ought to match the XML/YAML conventions now. Anything else?

stof · 2015-08-12T15:45:47Z

DependencyInjection/DoctrineExtension.php

+        * satisfy DBAL, which is expecting camelCasing.
+        *
+        */
+        $conversions = array('default_table_options' => 'defaultTableOptions');


we already have code doing this. See getConnectionOptions. Just add this option there

…echanism

DHager · 2015-08-15T01:22:10Z

@stof : Fixed the conversion step to use the existing mechanism. Thanks, didn't see it there.

DHager · 2015-09-01T04:35:43Z

@stof Is there anything else?

DHager · 2015-09-08T17:37:24Z

Ping

DHager · 2015-09-16T00:05:11Z

@stof: Ping

DHager · 2015-09-25T02:26:50Z

@stof: Ping

DHager · 2015-10-02T19:43:03Z

@stof : Weekly checkin.

DHager · 2015-10-16T20:30:06Z

@stof Anything else I can do to make this merge-ready? Personally speaking, it should let me avoid putting

    <options>
        <option name="charset">utf8mb4</option>
        <option name="collation">utf8mb4_unicode_ci</option>
    </options>

across hundreds of <Entity> definitions.

teohhanhui · 2015-10-28T03:01:23Z

Since @stof is not giving any response, perhaps it's time to ask the other maintainers...

@fabpot @beberlei

Allow defaultTableOptions to be configured

Since its now possible (doctrine/DoctrineBundle#420) to set the default character set for all tables using DoctrineBundle it can be mentioned in the docs

This PR was merged into the 3.0 branch. Discussion ---------- Update Doctrine UTF8 docs Since its now possible (doctrine/DoctrineBundle#420) to set the default character set for all tables using DoctrineBundle it can be mentioned in the docs Commits ------- dcd1126 Update Doctrine UTF8 docs

Allow defaultTableOptions to be configured from Symfony

a567952

DHager mentioned this pull request May 5, 2015

Change MySQL defaults from broken utf8 to fixed utf8mb4 doctrine/dbal#851

Closed

Fix up tests that weren't expecting to see an empty array for default…

d8c0b08

…TableOptions

Darien Hager added 2 commits May 22, 2015 10:52

Add example YAML configuration options

9a987db

Add XML examples (relying on Symfony's naming-normalization rules)

56e79cb

stof reviewed May 28, 2015
View reviewed changes

Darien Hager added 3 commits June 5, 2015 18:58

Add some unit-tests to verify configuration

fb4f7ac

Fix pluralization in XML, but not sure how to handle camel-vs-undersc…

9e69bef

…ore issues.

Update documentation due to XML tag pluralization change

53e3da5

Darien Hager added 2 commits June 5, 2015 19:34

Merge branch 'master' into default_table_options

888acbc

Fix unit tests from master that weren't expecting defaultTableOptions

d151729

samjarrett mentioned this pull request Jul 16, 2015

Steps to configure doctrine/orm for utf8mb4 aren't correct symfony/symfony-docs#5526

Closed

Rename all Symfony-level configs from defaultTableOptions to default_…

96c6606

…table_options (or dashed, if XML) Add renaming step to the extension so that DBAL layer is still satisfied seeing defaultTableOptions

stof reviewed Aug 12, 2015
View reviewed changes

Remove unnecessary custom option-key-renaming code, use an existing m…

0918e9e

…echanism

guilhermeblanco added a commit that referenced this pull request Nov 4, 2015

Merge pull request #420 from DHager/default_table_options

f3782a6

Allow defaultTableOptions to be configured

guilhermeblanco merged commit f3782a6 into doctrine:master Nov 4, 2015

mcfedr added a commit to mcfedr/symfony-docs that referenced this pull request Feb 15, 2016

Update Doctrine UTF8 docs

07f3a17

Since its now possible (doctrine/DoctrineBundle#420) to set the default character set for all tables using DoctrineBundle it can be mentioned in the docs

mcfedr mentioned this pull request Feb 15, 2016

Update Doctrine UTF8 docs symfony/symfony-docs#6274

Merged

mcfedr added a commit to mcfedr/symfony-docs that referenced this pull request Feb 15, 2016

Update Doctrine UTF8 docs

dba5234

Since its now possible (doctrine/DoctrineBundle#420) to set the default character set for all tables using DoctrineBundle it can be mentioned in the docs

mcfedr added a commit to mcfedr/symfony-docs that referenced this pull request Feb 15, 2016

Update Doctrine UTF8 docs

33021a7

Since its now possible (doctrine/DoctrineBundle#420) to set the default character set for all tables using DoctrineBundle it can be mentioned in the docs

mcfedr added a commit to mcfedr/symfony-docs that referenced this pull request Mar 8, 2016

Update Doctrine UTF8 docs

dcd1126

Since its now possible (doctrine/DoctrineBundle#420) to set the default character set for all tables using DoctrineBundle it can be mentioned in the docs

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow defaultTableOptions to be configured #420

Allow defaultTableOptions to be configured #420

DHager commented May 5, 2015

DHager commented May 21, 2015

stof commented May 22, 2015

DHager commented May 22, 2015

stof commented May 28, 2015

stof May 28, 2015

DHager commented Jun 6, 2015

DHager commented Jun 9, 2015

DHager commented Jul 16, 2015

stof commented Jul 20, 2015

DHager commented Jul 22, 2015

DHager commented Jul 22, 2015

DHager commented Jul 30, 2015

stof Aug 12, 2015

DHager commented Aug 15, 2015

DHager commented Sep 1, 2015

DHager commented Sep 8, 2015

DHager commented Sep 16, 2015

DHager commented Sep 25, 2015

DHager commented Oct 2, 2015

DHager commented Oct 16, 2015

teohhanhui commented Oct 28, 2015

Allow defaultTableOptions to be configured #420

Allow defaultTableOptions to be configured #420

Conversation

DHager commented May 5, 2015

DHager commented May 21, 2015

stof commented May 22, 2015

DHager commented May 22, 2015

stof commented May 28, 2015

stof May 28, 2015

Choose a reason for hiding this comment

DHager commented Jun 6, 2015

DHager commented Jun 9, 2015

DHager commented Jul 16, 2015

stof commented Jul 20, 2015

DHager commented Jul 22, 2015

DHager commented Jul 22, 2015

DHager commented Jul 30, 2015

stof Aug 12, 2015

Choose a reason for hiding this comment

DHager commented Aug 15, 2015

DHager commented Sep 1, 2015

DHager commented Sep 8, 2015

DHager commented Sep 16, 2015

DHager commented Sep 25, 2015

DHager commented Oct 2, 2015

DHager commented Oct 16, 2015

teohhanhui commented Oct 28, 2015