-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation on load fixtures command #280
Conversation
yceruto
commented
May 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more suggestion, other than that, this looks good 👍
Thanks @yceruto! |
@alcaeus Is there a plan to release a new version to get rid of this warning everywhere? Thank you. |
I’ll take time to do some housekeeping in the bundle next week 👍 |
3.2.0 is released. Thanks @yceruto! |
With the changes made in doctrine#280, this bundle is no longer compatible with DoctrineBundle < 1.10. Thus, we need to raise the minimum version in a patch release.
With the changes made in doctrine#280, this bundle is no longer compatible with DoctrineBundle < 1.10. Thus, we need to raise the minimum version in a patch release.
), E_USER_DEPRECATED); | ||
} | ||
|
||
parent::__construct($doctrine); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
The Symfony Command
constructor argument is waiting for a string and not an object. https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Console/Command/Command.php#L69
On previous SF versions (without PHP 7 type), it breaks here (https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Console/Command/Command.php#L660), which is calls by the setName
.
Running bin/console --env=test
for example returns
In Command.php line 659:
Warning: preg_match() expects parameter 2 to be string, object given
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use 3.2.2 which fixes this. Thanks!