Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$container is no longer available in Fixture class #308

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

Yondz
Copy link

@Yondz Yondz commented Apr 2, 2020

Since ee5eb61, Doctrine\Bundle\FixturesBundle\Fixture does not implement ContainerAwareInterface anymore and thus, $container is not part of this class anymore.

See ee5eb61#diff-8490d6a88059c82df2c98e6f2d0918d2

@alcaeus
Copy link
Member

alcaeus commented Apr 2, 2020

LGTM, but should target the current stable branch.

Since ee5eb61, Doctrine\Bundle\FixturesBundle\Fixture does not implement ContainerAwareInterface anymore and thus, $container is not part of this class anymore.

See doctrine@ee5eb61#diff-8490d6a88059c82df2c98e6f2d0918d2
@greg0ire greg0ire changed the base branch from master to 3.3.x April 2, 2020 16:32
@greg0ire greg0ire merged commit 39defca into doctrine:3.3.x Apr 2, 2020
@greg0ire
Copy link
Member

greg0ire commented Apr 2, 2020

Thanks @Yondz !

@greg0ire greg0ire added this to the 3.3.1 milestone Apr 11, 2020
@greg0ire greg0ire added the Bug label Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants