Remove deprecation layer #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrine/persistence already provides a deprecation layer for this by using class aliases: Doctrine\Common\Persistence\ManagerRegistry and Doctrine\Persistence\ManagerRegistry are two names for the same thing, there is no need for another layer here, and the type declaration can be restored as it was before.
SenseException
requested changes
Apr 13, 2020
This namespace has been deprecated
|
Not exactly what this PR aims to fix, but good points! Please review again. |
SenseException
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doctrine/persistencealready provides a deprecation layer for this byusing class aliases: Doctrine\Common\Persistence\ManagerRegistry and
Doctrine\Persistence\ManagerRegistry are two names for the same thing,
there is no need for another layer here, and the type declaration can be
restored as it was before.