Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return void annotation to silence deprecation msg #382

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Add return void annotation to silence deprecation msg #382

merged 1 commit into from
Apr 11, 2023

Conversation

PhilETaylor
Copy link
Contributor

can you please send a PR to add the @return void annotation? That's enough to express the intent and fix the deprecation.

ref #381 (comment)

Used single/one line annotation syntax as proposed elsewhere

//cc @nicolas-grekas

@PhilETaylor
Add return void annotation to silence deprecation msg
044dc45 
Add return void annotation to silence deprecation msg
@derrabus derrabus added this to the 3.4.3 milestone Apr 11, 2023
@derrabus derrabus merged commit 17a08ae into doctrine:3.4.x Apr 11, 2023
@derrabus
Copy link
Member

Thank you!

@github-actions github-actions bot mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
3.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilETaylor @derrabus