Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added return void annotation to suppress deprecation warnings in Command::configure() #387

Merged
merged 1 commit into from
May 2, 2023
Merged

Added return void annotation to suppress deprecation warnings in Command::configure() #387

merged 1 commit into from
May 2, 2023

Conversation

mickverm
Copy link
Contributor

@mickverm mickverm commented May 2, 2023

When version 3.4.3 of this bundle is used together with Symfony 6.3 (Symfony 6.3.0-BETA1), the following warning is logged:

Method "Symfony\Component\Console\Command\Command::configure()" might add "void" as a native return type declaration in the future. Do the same in child class "Doctrine\Bundle\FixturesBundle\Command\LoadDataFixturesDoctrineCommand" now to avoid errors or add an explicit @return annotation to suppress this message.

@mickverm mickverm changed the title Added return void annotation to suppress deprecation warnings in Command::configure() Added return void annotation to suppress deprecation warnings in Command::configure() May 2, 2023
@greg0ire greg0ire added this to the 3.4.4 milestone May 2, 2023
@derrabus derrabus merged commit 9ec3139 into doctrine:3.4.x May 2, 2023
@mickverm mickverm deleted the command-return-type-deprecation branch May 2, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants