Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2nd parameter (class) to getReference() call #482

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

olberger
Copy link
Contributor

@olberger olberger commented Dec 3, 2024

Since Doctrine data fixture v2, getReference() requires a second parameter, being the class.

This would address doctrine/data-fixtures#464 (comment)

Hth,

Since Doctrine data fixture v2, getReference() requires a second parameter, being the class
@greg0ire
Copy link
Member

greg0ire commented Dec 3, 2024

@ThomasLandauer @VincentLanglet please review

@greg0ire greg0ire added this to the 3.7.1 milestone Dec 3, 2024
@greg0ire greg0ire merged commit bd59519 into doctrine:3.7.x Dec 3, 2024
11 checks passed
@ThomasLandauer
Copy link
Contributor

Looks like I don't have enough rights to formally approve it ;-)
But +1 from me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants