Fix context unique #406
Merged
Fix context unique #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shit, some ugly commits... |
| @@ -151,6 +151,12 @@ protected function getExpectedIdentifiers(array $context = null) | |||
| ); | |||
| } | |||
|
|
|||
| if (is_object($context)) { | |||
There was a problem hiding this comment.
Are you sure that $context is an instance of this repository's class?
There was a problem hiding this comment.
No. We could add a check.
There was a problem hiding this comment.
Yeah, this code block should really be reached only if $className = $this->objectRepository->getClassName() && $context instanceof $className
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
UniqueValidator had a "use_context" option that could be set to false, however it could not work because the "getExpectedIdentifiers" was set to typehint to array, hence resulting in a runtime error.
It now makes the "use_context" option usable, by allowing to fetch identifiers from the instance.
Please merge asap :).