Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop prophecy in favour of PHPUnit mocks #794

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Nov 20, 2022

linked to #791

@fezfez
Copy link
Contributor Author

fezfez commented Nov 22, 2022

@driehle ping :neckbeard:

@driehle driehle added this to the 5.3.0 milestone Nov 22, 2022
@driehle driehle self-assigned this Nov 22, 2022
@driehle driehle changed the title drop prophecy Drop prophecy in favour if PHPUnit mocks Nov 22, 2022
Copy link
Member

@driehle driehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good to me!

@driehle driehle changed the title Drop prophecy in favour if PHPUnit mocks Drop prophecy in favour of PHPUnit mocks Nov 22, 2022
@driehle driehle requested a review from Ocramius November 22, 2022 10:37
@Ocramius
Copy link
Member

Thanks @fezfez!

@driehle driehle merged commit 80ecc80 into doctrine:5.3.x Nov 22, 2022
@driehle driehle mentioned this pull request Nov 22, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants