Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed exception type #489

Merged
merged 2 commits into from
Oct 15, 2018
Merged

Changed exception type #489

merged 2 commits into from
Oct 15, 2018

Conversation

blixit
Copy link
Contributor

@blixit blixit commented Oct 8, 2018

Changed exception interface 'Throwable' by the explicit class '\Exception' in order to fix #488

Changed exception interface 'Throwable' by the explicit class '\Exception' in order to fix doctrine#488
@blixit blixit mentioned this pull request Oct 8, 2018
DataCollector/CommandDataCollector.php Outdated Show resolved Hide resolved
@blixit
Copy link
Contributor Author

blixit commented Oct 10, 2018

Ok. This week I am busy, I will fix it this end of week, probably saturday.

Copy link
Contributor Author

@blixit blixit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed the updated code

DataCollector/CommandDataCollector.php Outdated Show resolved Hide resolved
@alcaeus
Copy link
Member

alcaeus commented Oct 15, 2018

Thanks @blixit!

@alcaeus alcaeus merged commit 9d5e095 into doctrine:master Oct 15, 2018
@alcaeus alcaeus added the bug label Oct 15, 2018
@alcaeus alcaeus self-assigned this Oct 15, 2018
@alcaeus alcaeus added this to the 4.0.0 milestone Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CommandDataCollector
3 participants