Allow passing env variables for port config

.travis.yml

@@ -33,6 +33,7 @@ services: mongodb
 
 install:
   - composer self-update
+  - pecl install memcached
   - pecl install -f mongodb-${DRIVER_VERSION}
   - composer update ${COMPOSER_FLAGS}
 

Tests/DependencyInjection/AbstractMongoDBExtensionTest.php

@@ -23,15 +23,17 @@
 use Symfony\Component\DependencyInjection\Container;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
-use Symfony\Component\DependencyInjection\ParameterBag\ParameterBag;
+use Symfony\Component\DependencyInjection\ParameterBag\EnvPlaceholderParameterBag;
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\Security\Core\User\UserInterface;
 use Vendor\Filter\BasicFilter;
 use Vendor\Filter\ComplexFilter;
 use Vendor\Filter\DisabledFilter;
 use function array_map;
 use function array_search;
+use function extension_loaded;
 use function reset;
+use function sprintf;
 
 abstract class AbstractMongoDBExtensionTest extends TestCase
 {
@@ -175,6 +177,31 @@ public function testLoadSimpleSingleConnection()
         $this->assertEquals('doctrine_mongodb.odm.default_connection.event_manager', (string) $container->getAlias('doctrine_mongodb.odm.event_manager'));
     }
 
+    public function testLoadCacheService()
+    {
+        if (! extension_loaded('memcached')) {
+            $this->markTestSkipped(sprintf('The "%s" test requires the memcached extension', __METHOD__));
+        }
+
+        $container = $this->getContainer();
+        $loader    = new DoctrineMongoDBExtension();
+        $container->registerExtension($loader);
+
+        $this->loadFromFile($container, 'mongodb_service_simple_single_connection');
+
+        $container->compile();
+
+        // Test retrieving the document manager
+        /** @var DocumentManager $documentManager */
+        $documentManager = $container->get('doctrine_mongodb.odm.default_document_manager');
+
+        /** @var MemcachedCache $cacheImplementation */
+        $cacheImplementation = $documentManager->getConfiguration()->getMetadataCacheImpl();
+        self::assertInstanceOf(MemcachedCache::class, $cacheImplementation);
+
+        $cacheImplementation->getMemcached()->getServerList();
+    }
+
     public function testLoadSingleConnection()
     {
         $container = $this->getContainer();
@@ -498,7 +525,7 @@ protected function getContainer($bundle = 'XmlBundle')
     {
         require_once __DIR__ . '/Fixtures/Bundles/' . $bundle . '/' . $bundle . '.php';
 
-        return new ContainerBuilder(new ParameterBag([
+        return new ContainerBuilder(new EnvPlaceholderParameterBag([
             'kernel.bundles'          => [$bundle => 'DoctrineMongoDBBundle\\Tests\\DependencyInjection\\Fixtures\\Bundles\\' . $bundle . '\\' . $bundle],
             'kernel.cache_dir'        => __DIR__,
             'kernel.compiled_classes' => [],

Tests/DependencyInjection/ConfigurationTest.php

@@ -489,6 +489,27 @@ public function testNullReplicaSetValue()
         $this->assertFalse(array_key_exists('replicaSet', $processedConfig['connections']['conn1']['options']));
     }
 
+    public function testPortFromEnvVariable()
+    {
+        $config = [
+            'document_managers' => [
+                'dm1' => [
+                    'metadata_cache_driver' => [
+                        'type'           => 'memcached',
+                        'class'          => 'fooClass',
+                        'host'           => 'host_val',
+                        'port'           => '%env(int:MEMCACHE_PORT)%',
+                        'instance_class' => 'instance_val',
+                    ],
+                ],
+            ],
+        ];
+
+        $processor       = new Processor();
+        $configuration   = new Configuration(false);
+        $processedConfig = $processor->processConfiguration($configuration, [$config]);
+    }
+
     /**
      * @dataProvider provideExceptionConfiguration
      */

Tests/DependencyInjection/Fixtures/config/yml/mongodb_service_simple_single_connection.yml

@@ -9,5 +9,5 @@ doctrine_mongodb:
         type: memcached
         class: Doctrine\Common\Cache\MemcachedCache
         host: localhost
-        port: 11211
-        instance_class: Memcached
+        port: '%env(int:MEMCACHE_PORT)%'
+        instance_class: Doctrine\Bundle\MongoDBBundle\Tests\MemcachedStub

Tests/MemcachedStub.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types = 1);
+
+namespace Doctrine\Bundle\MongoDBBundle\Tests;
+
+use function func_get_args;
+use Memcached;
+
+final class MemcachedStub extends Memcached
+{
+    public function addServer($host, $port, $weight = 0)
+    {
+        parent::addServer(...func_get_args());
+    }
+}