Document service repositories #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Oct 28, 2019
|
|
||
| .. code-block:: php | ||
|
|
||
| // src/Acme/StoreBundle/Repository/ProductRepository.php |
There was a problem hiding this comment.
Do we want to document the repositoryClass argument to the Document mapping again to be on the safe side?
There was a problem hiding this comment.
Not sure, previous chapter is all about that :) On the other hand we could add a comment in the code reminding user to set repositoryClass
There was a problem hiding this comment.
A short comment sounds sensible and should be sufficient if the previous section covers this in more detail 👍
malarzm
force-pushed
the
service-repositories-docs
branch
from
48c6829
to
03be272
Compare
greg0ire
reviewed
Oct 28, 2019
malarzm
force-pushed
the
service-repositories-docs
branch
from
03be272
to
71ffd1c
Compare
greg0ire
approved these changes
Oct 28, 2019
SenseException
approved these changes
Oct 29, 2019
malarzm
force-pushed
the
service-repositories-docs
branch
from
71ffd1c
to
4542813
Compare
jmikola
reviewed
Nov 6, 2019
| } | ||
|
|
||
| The ``ServiceDocumentRepository`` class your custom repository is extending allows you to | ||
| leverage Symfony's `autowiring`_ and `autoconfiguration`_. To register all your repositories |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #516