Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong data collector signature #604

Merged
merged 4 commits into from
Nov 28, 2019

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Nov 27, 2019

When adding compatibility with Symfony 5 in #602, we missed that Symfony 3.4 was still supported. Supporting 3.4 and 5.0 at the same time is not possible due to a method signature change in the data collector.

This PR fixes this issue by removing support for Symfony 3.4, which will be released as 4.1.0. This has the following implications:

  • 4.0.* will no longer be supported. Users currently using Symfony 3.4 alongside ODM 2.0 should upgrade to Symfony 4.3 or newer as soon as possible.
  • 4.1.* will be the new supported release for ODM 2
  • 3.6.* still supports Symfony 3.4 and ODM 1.3 and will continue to do so until the end of life of ODM 1 is reached.

@alcaeus alcaeus added the bug label Nov 27, 2019
@alcaeus alcaeus added this to the 4.1.0 milestone Nov 27, 2019
@alcaeus alcaeus self-assigned this Nov 27, 2019
@alcaeus alcaeus mentioned this pull request Nov 28, 2019
@alcaeus alcaeus merged commit c27fefe into doctrine:master Nov 28, 2019
@alcaeus alcaeus deleted the fix-wrong-data-collector-signature branch November 28, 2019 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant