-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Section for custom types in configuration chapter #638
Conversation
Resources/doc/config.rst
Outdated
@@ -214,6 +214,39 @@ The following configuration shows a bunch of mapping examples: | |||
</doctrine_mongodb:config> | |||
</container> | |||
|
|||
Custom types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize "Types" since this is a title
Resources/doc/config.rst
Outdated
|
||
doctrine_mongodb: | ||
types: | ||
# following two definitions are equivalent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, you're saying that the value can either be a FQCN string directly or an object with the FQCN string under a class
property. I think it may be simpler to just present one style in the documentation example, though, unless there is a legitimate reason users would need to use the more verbose syntax (perhaps if other options beyond class
were expected).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not right now, indeed it'll be better to just show simpler syntax 👍
Resources/doc/config.rst
Outdated
types: | ||
|
||
# Prototype | ||
name: Fully\Qualified\Class\Name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest using "custom_type" instead of "name" here, for consistency with the previous example. Likewise in the XML below.
Closes #632