Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests to GitHub Actions #660

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Conversation

franmomu
Copy link
Contributor

This is based on doctrine/mongodb-odm#2250

I've changed to check just Symfony maintained versions 4.4 and 5.1.

Some doubts:

I don't know if composer global require --no-progress --no-scripts --no-plugins symfony/flex dev-master is necessary.
And also about this:

    # Test dev versions
    - php: 7.3
      if: type = cron
      env: DEV COMPOSER_FLAGS="-n --prefer-dist"

The other cases I think they are covered.

@greg0ire
Copy link
Member

Please also update the README badge and .gitattributes

@greg0ire
Copy link
Member

greg0ire commented Nov 29, 2020

The line with symfony/flex was introduced by @alcaeus and @chalasr in 8fcefac as part of #602 . So was the line with cron.

@greg0ire greg0ire requested a review from alcaeus November 29, 2020 18:59
@greg0ire
Copy link
Member

@chalasr can you please review this?

@chalasr
Copy link
Contributor

chalasr commented Nov 29, 2020

Installing flex globally used to speed up composer package downloads thanks to parallelized prefetching. That's not useful anymore on Composer 2

@greg0ire
Copy link
Member

Discussed with @alcaeus about the cron, and we can ignore it for now.

@greg0ire greg0ire merged commit 94372f5 into doctrine:4.3.x Nov 30, 2020
@greg0ire
Copy link
Member

Thanks @franmomu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants