add attribute driver support #692
Conversation
IonBazan
force-pushed
the
attribute-driver
branch
3 times, most recently
from
91b620a to
9e56b2d
Compare
|
@IonBazan if you want to see whether static analysis is green or add some test feel free to require ODM's 2.3.x branch in composer.json. Later we'll drop the change once 2.3.0 is tagged properly |
|
Also it'd be great to check and update the docs. They definitely need some love since they still mention |
|
For the docs we could also add "PHP (attributes)" section for mapping examples: https://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/first_steps.html#creating-a-document-class |
|
Alright, I've temporarily added |
|
As suggested in doctrine/mongodb-odm#2344 (comment), it would be nice to add some tests like in https://github.com/doctrine/DoctrineBundle/pull/1322/files |
IonBazan
force-pushed
the
attribute-driver
branch
from
9606285 to
5c76cd0
Compare
| @@ -176,7 +176,7 @@ The following configuration shows a bunch of mapping examples: | |||
| mappings: | |||
| MyBundle1: ~ | |||
| MyBundle2: xml | |||
| MyBundle3: { type: annotation, dir: Documents/ } | |||
| MyBundle3: { type: attribute, dir: Documents/ } | |||
There was a problem hiding this comment.
I think it would be better if we keep annotation example and add a new one for attribute
| #[MongoDB\Id] | ||
| protected string $id; | ||
|
|
||
| #[MongoDB\Field(type: 'string')] |
There was a problem hiding this comment.
Maybe in our examples we could suggest to use constants like Doctrine\ODM\MongoDB\Types\Type::STRING
There was a problem hiding this comment.
It should be changed in annotation examples then too but I think this is a candidate for a separate PR.
I don't see the constants usages in ORM docs neither and I don't think it's clear to new developers.
This PR adds support for upcoming attribute mapping driver introduced in doctrine/mongodb-odm#2344.