Deprecate some unused DoctrineODMCommand methods
#693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
changed the title
DoctrineODMCommand methods
franmomu
force-pushed
the
command_deprecations
branch
2 times, most recently
from
160cd0a to
eca62c0
Compare
malarzm
approved these changes
Aug 16, 2021
There was a problem hiding this comment.
As in another PR with deprecations: could you please add a UPGRADE-4.4.md file mentioning the deprecation and UPGRADE-5.0.md mentioning removal? This way the change won't fall through the cracks when we release 5.0 and it's what we try to do with ODM changes.
The deprecated methods are not used anymore.
franmomu
force-pushed
the
command_deprecations
branch
from
5a3b171 to
440e093
Compare
hasc
pushed a commit
to aboutcoders/DoctrineMongoDBBundle
that referenced
this pull request
Sep 10, 2021
* Add tests for Commands * Remove ContainerAwareInterface and deprecate methods The deprecated methods are not used anymore. * Bump symfony/console to 4.4.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some functional tests to commands that are not proxied from
doctrine/mongodb-odm.It also removes implementing
ContainerAwareInterfacefromDoctrineODMCommandand deprecates some methods that are not used anymore.