-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility with Symfony 6 #710
Conversation
|
|
@franmomu it does not seem that your PR (symfony/symfony#43917) is getting merged for 5.4 or 6.0 (it is target to 6.1), does that affect this PR in any way? We only miss this one to add sf 6 to three more Sonata bundles. |
I've written a comment there, thanks for pointing that out. In any case, that's when using auto_mapping, we can always set it explicitly, I'll try to change it later today or tomorrow to see if it passes the tests. |
@franmomu I think let's add the types everywhere, let's just put it to the UPGRADE file that in an (unlikely ;) ) event somebody did extend our classes, they need to adjust their code. It's a small BC break they'll need to live with :) |
#713 merged :) |
All 🟢 now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Thanks @franmomu! |
There are many BC breaks here
DoctrineMongoDBExtension
: I think they could be acceptable since I think it's quite unusual that someone extends from it.DoctrineMongoDBBundle
: The same thing, I think it is unlikely that someone extends it.MongoDBQueryBuilderLoader
andDocumentType
: I'm not sure about these ones, should we comment on [META] Symfony 6 return type declarations symfony/symfony#43021? or do you think it's safe to add the return types.Tests will be probably fixed with symfony/symfony#43917