Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony/deprecation-contracts 3+ #724

Merged
merged 1 commit into from
Jan 1, 2022
Merged

Conversation

kbond
Copy link
Contributor

@kbond kbond commented Dec 31, 2021

No description provided.

@malarzm
Copy link
Member

malarzm commented Jan 1, 2022

Thanks @kbond for the contribution! May I ask what changed in 3.0.0? As this is a major release I'd feel more comfortable knowing alas there is no info about the version (frankly about most of versions) on https://github.com/symfony/deprecation-contracts/releases

@malarzm malarzm added this to the 4.4.2 milestone Jan 1, 2022
@malarzm malarzm added the Task label Jan 1, 2022
@kbond
Copy link
Contributor Author

kbond commented Jan 1, 2022

Hey @malarzm, Symfony releases new major versions of the contracts with new major versions of Symfony. Here are the 3.0 changes - nothing major, just a typehint really.

I had a dependency problem where composer wouldn't pull in 4.4 of this bundle because it only allows 2.x of symfony/deprecation-contracts.

@malarzm malarzm changed the base branch from 4.5.x to 4.4.x January 1, 2022 17:30
@malarzm malarzm merged commit 6da8fd0 into doctrine:4.4.x Jan 1, 2022
@malarzm
Copy link
Member

malarzm commented Jan 1, 2022

Thanks for the explanation! I've retargeted PR to 4.4.x and gonna release later today :)

@kbond kbond deleted the patch-1 branch January 1, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants