Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire the EntityArgumentResolver #754

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Wire the EntityArgumentResolver #754

merged 1 commit into from
Mar 5, 2023

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Jan 2, 2023

Resolves #753

Despite "Entity" being in it's name, the EntityValueResolver & #[MapEntity] attribute work with MongoDB documents as well, it's just missing the wiring.
This PR is basically a copy of doctrine/DoctrineBundle#1554 with some minor adjustments.

@malarzm malarzm added the Feature label Jan 2, 2023
@malarzm malarzm added this to the 4.6.0 milestone Jan 2, 2023
@malarzm
Copy link
Member

malarzm commented Jan 2, 2023

@HypeMC don't mind Psalm's failure (unless you want to), we'll deal with that separately

@franmomu franmomu closed this Jan 8, 2023
@franmomu franmomu reopened this Jan 8, 2023
@deluxetom
Copy link

Anything I could help with to get this PR merged? this seems ready to me

@franmomu franmomu merged commit ab30f88 into doctrine:4.6.x Mar 5, 2023
@franmomu
Copy link
Contributor

franmomu commented Mar 5, 2023

Thanks @HypeMC!

@HypeMC HypeMC deleted the evr-wiring branch March 5, 2023 13:08
@boskos-q
Copy link

boskos-q commented Mar 7, 2023

Thanks @franmomu for merging this!
One more thing, when can we expect for 4.6.x to be released as we'd really need this feature?
Also I don't want to sound like an ignorant dev who just asks for a feature, but if there is anything I could do to help for this release to happen, please do tell. I'll be more than happy to do it :)

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Mar 7, 2023

This should be updated to leverage symfony/symfony#48992! (adding attribute "name" on the tag)

@franmomu
Copy link
Contributor

franmomu commented Mar 8, 2023

@boskos-q I'm sorry, but we don't really know, I hope it won't take too much.
You can always try the 4.6.x branch in your project and that would help us to test next release.

There is also #770 that needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move and extend Symfony 6.2 #[MapEntity] to support ODM as well
7 participants