Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PHP 7.4 for phpcs #768

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Use PHP 7.4 for phpcs #768

merged 2 commits into from
Mar 8, 2023

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Mar 5, 2023

Extracted from #765 so it would be easier to review

@franmomu franmomu added the Task label Mar 5, 2023
@franmomu franmomu added this to the 4.6.0 milestone Mar 5, 2023
SenseException
SenseException reviewed Mar 5, 2023
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPCS config still has <config name="php_version" value="70200"/>. This PR would be a great opportunity to fix this, but shouldn't the PHP version rather be set in the workflow?

@greg0ire
Copy link
Member

greg0ire commented Mar 6, 2023

@SenseException I don't think so: contributors should have the same php_version value regarless of what version of PHP they use.

franmomu
franmomu commented Mar 7, 2023
View reviewed changes
phpcs.xml.dist
<config name="php_version" value="70200"/>
<config name="php_version" value="70400"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review @SenseException, the php_version is already set here

@IonBazan IonBazan requested a review from SenseException March 7, 2023 07:33
@IonBazan IonBazan merged commit 74412fe into doctrine:4.6.x Mar 8, 2023
@franmomu franmomu deleted the php_cs_7.4 branch March 8, 2023 06:51
alcaeus added a commit that referenced this pull request Jul 20, 2023
@alcaeus
Merge branch '4.6.x' into 4.5.x-merge-up-into-4.6.x_9JgLVdSd
017ca26 
* 4.6.x:
  Drop support of unmaintained versions of Symfony (#771)
  Fix CS (#772)
  Use PHP 7.4 for phpcs (#768)
  Use PHPUnit 9 methods
  Add property types
  Use PHP 7.4 syntax
  Wire the EntityArgumentResolver
  Add missing void types
  Allow doctrine/annotations 2
  Update to psalm 5
  Drop support of PHP < 7.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IonBazan IonBazan IonBazan approved these changes

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@franmomu @greg0ire @SenseException @IonBazan