fix: UniqueEntity::$service is considered final

[divine]

Fix #741.

[franmomu]

Thanks @divine! what about using the suggested approach by symfony:

Public and protected properties are now considered final; instead of overriding a property, consider setting its value in the constructor

That way a user can use Unique with their own service without overriding the class (I guess it unlikely to happen, but it could happen)

[divine]

Does it look better now?

Thanks!

[franmomu]

Suggested change

	* @param bool|array|string $ignoreNull The combination of fields that ignore null values
	*/
	public function __construct(
	$fields,
	string $message = null,
	string $service = 'doctrine_odm.mongodb.unique',
	string $em = null,
	string $entityClass = null,
	string $repositoryMethod = null,
	string $errorPath = null,
	bool|string|array $ignoreNull = null,
	*/
	public function __construct(
	$fields,
	string $message = null,
	string $service = 'doctrine_odm.mongodb.unique',
	string $em = null,
	string $entityClass = null,
	string $repositoryMethod = null,
	string $errorPath = null,
	bool $ignoreNull = null,

Now I see this, union types are introduced in PHP >= 8.0, so I guess we should stick to Symfony 5.4 constructor: https://github.com/symfony/symfony/blob/8492f10d29e929a83ccf6c306d40dbad69c9c80b/src/Symfony/Bridge/Doctrine/Validator/Constraints/UniqueEntity.php#L55

Adding a "simple" test would be awesome, we would have realized of this. (Test added)

[malarzm]

Thanks @divine and @franmomu!

[divine]

Hello,

Any ETA for a new release with this fix?

Thanks!

[malarzm]

Here you go :) https://github.com/doctrine/DoctrineMongoDBBundle/releases/tag/4.6.1