Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add $buildDir parameter to warmUp method" #798

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Revert "Add $buildDir parameter to warmUp method" #798

merged 2 commits into from
Dec 9, 2023

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Dec 9, 2023

This reverts commit dc54819.

Since we are not adding BC breaks in 4.7, should we maybe revert this commit? which was the only one adding a BC break in #789

@franmomu franmomu added the Task label Dec 9, 2023
@franmomu franmomu added this to the 4.7.0 milestone Dec 9, 2023
@GromNaN
Copy link
Member

GromNaN commented Dec 9, 2023

Sure. And let's re-apply in 5.0.x

@GromNaN
Copy link
Member

GromNaN commented Dec 9, 2023

Actually, cache warmers should be @internal too.

@franmomu
Copy link
Contributor Author

franmomu commented Dec 9, 2023

Actually, cache warmers should be @internal too.

Yep, I'm make them and ignore the direct deprecation

@franmomu
Copy link
Contributor Author

franmomu commented Dec 9, 2023

Actually, cache warmers should be @internal too.

Yep, I'm make them and ignore the direct deprecation

They already are

@GromNaN
Copy link
Member

GromNaN commented Dec 9, 2023

They already are

Then, you don't have to revert. Changing internal classes is never a breaking change.

@franmomu
Copy link
Contributor Author

franmomu commented Dec 9, 2023

They already are

Then, you don't have to revert. Changing internal classes is never a breaking change.

But it was marked as internal in 4.4, someone could upgrade from 4.3 to 4.7

@GromNaN
Copy link
Member

GromNaN commented Dec 9, 2023

Alright.

@GromNaN GromNaN merged commit 1c10e04 into doctrine:4.7.x Dec 9, 2023
13 checks passed
@GromNaN
Copy link
Member

GromNaN commented Dec 9, 2023

Thank you @franmomu

@franmomu franmomu deleted the revert_bc_break branch December 10, 2023 07:47
GromNaN added a commit that referenced this pull request Dec 10, 2023
@GromNaN
Merge branch '4.7.x' into 5.0.x
a4903da 
* 4.7.x:
  Mark classes as internal: command and compile pass (#800)
  Revert "Add $buildDir parameter to warmUp method" (#798)
@GromNaN
Copy link
Member

GromNaN commented Dec 10, 2023 •
edited
Loading

There was a conflict when upmerging into 5.0.x, I kept the modified changes, so we don't have to reapply this breaking changes for the new major version. See a4903da

@github-actions github-actions bot mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@franmomu @GromNaN