Expose transaction setting #814
Conversation
alcaeus
force-pushed
the
expose-transaction-setting
branch
from
fbc7086
to
d8b4ce1
Compare
alcaeus
force-pushed
the
expose-transaction-setting
branch
from
e5ac0e6
to
88ab999
Compare
alcaeus
force-pushed
the
expose-transaction-setting
branch
from
88ab999
to
67463b6
Compare
|
Updated to target 5.0.x, which we may bump to 5.1.x. I've also added logic to support older ODM versions that don't support transactional flushes. We can decide whether to bump the ODM requirement at a later date. |
Will do once we have a 5.1.x branch - release automation doesn't handle pre-releases very gracefully, so once 5.0.0 is tagged everything should be in order. |
|
Ah 5.0.0 is still in RC phase 🙈 |
|
|
||
| public function testTransactionalFlushConfigurationWhenNotSupported(): void | ||
| { | ||
| if (method_exists(ODMConfiguration::class, 'setUseTransactionalFlush')) { |
There was a problem hiding this comment.
This is a weak test. If the method is renamed, the test is skipped while it should fail.
I think it would be more robust to use Composer\InstalledVersions:
Composer\InstalledVersions::satisfies(new VersionParser, 'doctrine/mongodb-odm', '>=2.7@dev')There was a problem hiding this comment.
Updated. I wasn't even aware this existed. This is simply lovely :)
There was a problem hiding this comment.
I see 3 skipped tests, is the version contraint correct?
This complements doctrine/mongodb-odm#2586 by exposing the
use_transactional_flushsetting to the bundle configuration.