Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.8.2 bump #127

Merged
merged 1 commit into from
Mar 31, 2015
Merged

Release 0.8.2 bump #127

merged 1 commit into from
Mar 31, 2015

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Mar 27, 2015

I'm speaking with @Ocramius and this is my proposal of release.
I found into the story the last commit with DoctrineModule 0.8.* and PHP >= 5.3
In my opinion we can tag in this point the 0.8.2 the last version before changeing in 0.9.*, security issues excluded.

After this commit the master branch support DoctrineModule 0.9.* and PHP >= 5.4

I'm speaking with @Ocramius and this is my proposal of release.
I found into the story the last commit with DoctrineModule 0.8.* and PHP >= 5.3
In my opinion we can tag in this point the 0.8.2 the last version before changeing in 0.9.*, security issues excluded.

After this commit the master branch support DoctrineModule 0.9.* and PHP >= 5.4
@gianarb gianarb mentioned this pull request Mar 27, 2015
@gianarb
Copy link
Contributor Author

gianarb commented Mar 27, 2015

Hi @fabiocarneiro thanks for your feedback and sorry if I closed the last PR :)
This PR rapresent in the best way my proposal

@fabiocarneiro
Copy link
Contributor

@gianarb I didn't understand how adding this to this version/0.8.2 branch would make the tests pass in master on php 5.3. You'll probably tag this branch as 0.8.2, but master will still have php 5.3 with doctrine-module 0.9, which will still fail. Am I missing something?

@gianarb
Copy link
Contributor Author

gianarb commented Mar 27, 2015

This is only a different approach..
We can revert 53ee2e8, we can tag new release and re-merge it into the master or this flow.. :)

@fabiocarneiro
Copy link
Contributor

@gianarb What is holding us in this topic? Do you need someone else to merge and tag, since this commit is yours?

Also, I guess you will probably tag from this 0.8.2 branch, right? If so, you probably don't need to wait the release to merge my #125 and #124.

I would like to get this merged fast, otherwise i'll have to replicate this factory in many repositories. 😢

@gianarb
Copy link
Contributor Author

gianarb commented Mar 28, 2015

@fabiocarneiro I understand your opinion, I can merge and tagging all but I'm not only 👍

Draft Blogpost is ready.. :)
Another little piece :)

@Ocramius
Copy link
Member

I'll tag nao

@Ocramius Ocramius added RFC and removed RFC labels Mar 31, 2015
@Ocramius Ocramius self-assigned this Mar 31, 2015
@Ocramius Ocramius added this to the 0.8.2 milestone Mar 31, 2015
Ocramius added a commit that referenced this pull request Mar 31, 2015
@Ocramius Ocramius merged commit 5f4b434 into doctrine:version/0.8.2 Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants