Remove support for old PHP versions #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -38,7 +38,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=5.4", | |||
| "php": "~5.5 || ~7.0", | |||
There was a problem hiding this comment.
How can you claim version 7 is supported if you're not testing it? There should be a symmetric change in .travis.yml.
There was a problem hiding this comment.
Allow me to quote myself:
While ODM does not officially support PHP 7 (due to lack of support of the legacy MongoDB driver it relies on), this allows people to use polyfills for ext-mongo and continue using ODM.
|
Thanks @alcaeus |
gianarb
pushed a commit
that referenced
this pull request
Mar 22, 2016
Remove support for old PHP versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops support for PHP 5.4, which is no longer supported. The version constraint in composer.json is also updated to allow PHP 7. While ODM does not officially support PHP 7 (due to lack of support of the legacy MongoDB driver it relies on), this allows people to use polyfills for
ext-mongoand continue using ODM.