Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PHP 8.4 #769

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Allow PHP 8.4 #769

merged 2 commits into from
Jan 28, 2025

Conversation

driehle
Copy link
Member

@driehle driehle commented Jan 23, 2025

Closes #767

@driehle driehle added the Enhacement New feature or request label Jan 23, 2025
@driehle driehle added this to the 6.3.0 milestone Jan 23, 2025
@driehle driehle force-pushed the feat/php84 branch 4 times, most recently from 8b14bf3 to 02f108e Compare January 24, 2025 14:49
@FabianKoestring
Copy link
Contributor

Is there a schedule for this PR/Milestone?

@driehle
Copy link
Member Author

driehle commented Jan 27, 2025

@FabianKoestring See the related ticket. We'll need laminas/laminas-serializer#73, otherwise you won't be able to install DoctrineORMModule in PHP 8.4 without using --ignore-platform-req=php (and, in contrast, if you were using ignore-platform-req, you could aready use DoctrineORMModule with PHP 8.4 right now).

@FabianKoestring
Copy link
Contributor

https://github.com/laminas/laminas-serializer/releases/tag/2.18.0 👌

@driehle
Copy link
Member Author

driehle commented Jan 28, 2025

Removed again --ignore-platform-req=php for PHP 8.4, CI passes now as expected with the new release of laminas-serializer.

@driehle driehle marked this pull request as ready for review January 28, 2025 08:28
@driehle driehle merged commit 189162f into doctrine:6.3.x Jan 28, 2025
16 checks passed
@driehle driehle deleted the feat/php84 branch January 28, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhacement New feature or request
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

Add support for PHP 8.4 to version 6
2 participants
@driehle @FabianKoestring