Add PHP 8 compatibility and Use github actions as test CI #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/add-gitlab-actions
branch
2 times, most recently
from
df45672 to
c82f8b7
Compare
1 task
alexander-schranz
force-pushed
the
feature/add-gitlab-actions
branch
4 times, most recently
from
b08fa3e to
f6e8281
Compare
|
Hi! Nice contribution! Can you please make it closer to our template? https://github.com/doctrine/.github/blob/main/workflow-templates/continuous-integration.yml (most notably by using |
alexander-schranz
force-pushed
the
feature/add-gitlab-actions
branch
4 times, most recently
from
c1b5d70 to
4ea2d89
Compare
|
@greg0ire thx for the feedback did change that and tests are now green. Github will only show them here when this is merged so state of the PR CI can be seen here: alexander-schranz#1 |
52 tasks
greg0ire
reviewed
Jan 16, 2021
Looks like they no longer are green |
alexander-schranz
force-pushed
the
feature/add-gitlab-actions
branch
from
1f81aae to
aa10ed6
Compare
Closed
alexander-schranz
force-pushed
the
feature/add-gitlab-actions
branch
2 times, most recently
from
0d77482 to
b26bb8c
Compare
greg0ire
approved these changes
Jan 16, 2021
greg0ire
force-pushed
the
feature/add-gitlab-actions
branch
from
b26bb8c to
303c0ab
Compare
Co-Authored-By: Alexander Schranz <alexander@sulu.io>
Co-Authored-By: Alexander Schranz <alexander@sulu.io>
greg0ire
force-pushed
the
feature/add-gitlab-actions
branch
from
303c0ab to
45a9d55
Compare
|
Thanks a lot @alexander-schranz ! |
|
@greg0ire thx for the quick review! Is it possible to release this soon., so I can check if the symfony-cmf packages work as expected. |
|
@greg0ire Thx for tagging 🙏 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See alexander-schranz#1 for Github action run.