Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass context in second argument of annotation constructor #291

Closed
wants to merge 1 commit into from

Conversation

zorn-v
Copy link

@zorn-v zorn-v commented Oct 31, 2019

No description provided.

@alcaeus
Copy link
Member

alcaeus commented Oct 31, 2019

Please explain the reason for your patch and add a test for it. Thanks.

@zorn-v
Copy link
Author

zorn-v commented Oct 31, 2019

Reason - to show informational errors (e.g. validation in constructor)
Something like Parameter "param" is invalid for "@MyAnnotation" in class App\ClassWithAnnotation

@zorn-v
Copy link
Author

zorn-v commented Nov 1, 2019

Test added

@greg0ire
Copy link
Member

greg0ire commented Nov 1, 2019

Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble. Please include the reason you gave in your commit message

How to do that?

  1. git rebase -i origin/1.9, assuming origin is a git remote that points to this repository, and not your fork. If you're not sure what your remotes are, run git remote -vvv, there should be your fork and the holy/reference/base/origin/whatever-you-call-it repository.
  2. A window will show up with many lines, replace pick with fixup on every line but the first one
  3. Close your editor, git should do its magic, and you should end up with one commit
  4. Use git push --force to overwrite what you already push. Don't forget the --force option otherwise git will try to merge both things together.

To show informational errors (e.g. validation in annotation constructor)
Something like 'Parameter "param" is invalid for "@MyAnnotation" in class App\ClassWithAnnotation'
@alcaeus alcaeus changed the base branch from 1.9 to master April 1, 2020 11:26
@beberlei
Copy link
Member

As we move towards #369 with named arguments in constructor for attribute compatibility I will close this PR, as we shouldn't add new minor features anymore.

@beberlei beberlei closed this Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants