Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NamedArgumentConstructor to reserved annotations #419

Merged
merged 1 commit into from
Jul 17, 2021

Conversation

derrabus
Copy link
Member

When introducing the NamedArgumentConstructor annotation, I accidentally created the edge-case of acore annotation that needs to be imported. This is not the case for other core annotations like Annotation or Target. This PR attempts to fix that.

@greg0ire greg0ire merged commit f96567b into doctrine:1.13.x Jul 17, 2021
@greg0ire greg0ire added this to the 1.13.2 milestone Jul 17, 2021
@greg0ire
Copy link
Member

Thanks @derrabus !

@derrabus derrabus deleted the bugfix/ignore-nac-annotation branch July 17, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants