Hotfix: match escaped quotes (revert #44) #50
Conversation
…ows a longer sequence to be parsed Note that this doesn't solve the stack overflow issue with `preg_split()`, but just increases the size of the string that could be matched.
| @@ -84,7 +84,7 @@ protected function getCatchablePatterns() | |||
| return array( | |||
| '[a-z_\\\][a-z0-9_\:\\\]*[a-z_][a-z0-9_]*', | |||
| '(?:[+-]?[0-9]+(?:[\.][0-9]+)*)(?:[eE][+-]?[0-9]+)?', | |||
| '"(?:[^"])*"', | |||
| '"(?:""|[^"])*"', | |||
There was a problem hiding this comment.
This pattern doesn't prevent PHP from killing itself because of a preg_split() stack overflow, but at least makes it possible to pass in a string longer than 10240 chars, which is enough for our use-cases.
There was a problem hiding this comment.
Note that this is a normal problem for anything using a (?: pattern combined with |
There was a problem hiding this comment.
@Ocramius I think this regex could actually use a possessive quantifier, which would limit the stack overflow even more by forbidding to backtrack. In this case, the possessive regex should match the same cases than the non-possessive one (to be checked by the testsuite though): '"(?:""|[^"])*+"',
There was a problem hiding this comment.
Works indeed, thanks for the suggestion!
|
Hello, FYI, we encountered the BC Break in our existing code base with, ``* @Assert\Choice(choices={"""", "'"}, message="The value must be one of "" or '")` |
|
@nidup this issue fixes exactly that |
|
@Ocramius perfect, thank you ! for now we tag a patch in our project to force the 1.2.1 in composer.json |
|
@nidup I'll likely tag again later today. |
…e stack overflows in `preg_split()`
…preg_split()` internal overflows As per @stof's suggestion
Hotfix: match escaped quotes (revert #44)
See #44