Skip to content

Update to v2 of the action #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2020
Merged

Update to v2 of the action #196

merged 3 commits into from
Jun 7, 2020

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Jun 3, 2020

Composer v2.0.0-alpha1 was released today, this will prevent upgrading
to it by mistake.

See shivammathur/setup-php#229

Composer v2.0.0-alpha1 was released today, this will prevent upgrading
to it by mistake.

See shivammathur/setup-php#229
@greg0ire greg0ire requested a review from a team June 3, 2020 19:49
@greg0ire greg0ire mentioned this pull request Jun 3, 2020
SenseException
SenseException previously approved these changes Jun 6, 2020
beberlei
beberlei previously approved these changes Jun 7, 2020
@kukulich
Copy link
Contributor

kukulich commented Jun 7, 2020

Btw action/cache has also version 2: https://github.blog/changelog/2020-05-27-github-actions-v2-cache-actions/

And actions/checkout version should be specified with v2: https://github.com/actions/checkout#usage

greg0ire added 2 commits June 7, 2020 10:12
Actions use semver, there is no reason to pin so hard to a specific
version.
@greg0ire greg0ire dismissed stale reviews from beberlei and SenseException via da4dc67 June 7, 2020 08:13
@greg0ire greg0ire requested review from beberlei, SenseException and a team June 7, 2020 08:20
@greg0ire greg0ire merged commit 40d999d into doctrine:master Jun 7, 2020
@greg0ire greg0ire deleted the fix-build branch June 7, 2020 13:31
@greg0ire greg0ire self-assigned this Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants