Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slevomat ReturnTypeHintSpacing: remove default spacesCountBeforeColon configuration #201

Open
wants to merge 1 commit into
base: 8.2.x
Choose a base branch
from

Conversation

bendavies
Copy link

…CountBeforeColon configuration that is the default
@bendavies bendavies requested a review from a team as a code owner June 18, 2020 20:55
greg0ire
greg0ire previously approved these changes Jun 18, 2020
@@ -368,11 +368,7 @@
<!-- Require one space between typehint and variable, require no space between nullability sign and typehint -->
<rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHintSpacing"/>
<!-- Require space around colon in return types -->
Copy link
Member

@morozov morozov Jun 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is no longer valid. The space is required only after the colon.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, the included psr12 sniffs enforce this. the comment seems redundant and can be removed?

SenseException
SenseException previously approved these changes Jun 20, 2020
Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 on this one: if slevomat/coding-standard decide to change it in future versions, this will generate maintenance for us. Explicit vs. implicit here

@kukulich
Copy link
Contributor

I can promise I'll not change it :D

@greg0ire greg0ire changed the base branch from master to 8.2.x October 25, 2020 10:06
@greg0ire greg0ire dismissed stale reviews from SenseException and themself October 25, 2020 10:06

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants